lf-queue: Rewrite based on Nikolaev's paper and hazard pointers #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
lf-queue/atomics.h
Outdated
| #define ATOMIC_RELEASE atomic_flag_clear | ||
|
|
||
| #define ATOMIC_SUB atomic_fetch_sub | ||
| #define ATOMIC_SUB64 ATOMIC_SUB |
There was a problem hiding this comment.
ATOMIC_SUB64 is not really used. Drop it.
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
jserv
reviewed
Jun 21, 2023
lf-queue/lfq.c
Outdated
| struct lfq_node *p = ctx->fph; | ||
| if ((!atomic_load(&p->can_free)) || (!atomic_load(&p->free_next)) || | ||
| in_hp(ctx, (struct lfq_node *) p)) | ||
| goto final; |
There was a problem hiding this comment.
Instead of using goto, can you simply use break statement?
jserv
reviewed
Jun 21, 2023
jserv
changed the title
jserv
reviewed
Jun 22, 2023
lf-queue/README.md
Outdated
| @@ -1,8 +1,5 @@ | |||
| # Multithreaded Bounded Lock-free Queue | |||
| # lfq | |||
| The lock-free queue implemented is based on the paper [A Scalable, Portable, and Memory-Efficient Lock-Free FIFO Queue](https://drops.dagstuhl.de/opus/volltexte/2019/11335/pdf/LIPIcs-DISC-2019-28.pdf) by Ruslan Nikolaev. | |||
There was a problem hiding this comment.
Replace "implemented" with "implementation."
jserv
reviewed
Jun 22, 2023
jserv
reviewed
Jun 22, 2023
Instead of using the old implementation, a concurrent queue based on Nikolaev's paper and hazard pointers is provided. The program has been rewritten using C11 Atomics to support other processor architectures, and it has solved the data race issues, enabling it to pass the runtime detection of Thread Sanitizer.
|
Thank @csm1735 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the old implementation, a concurrent queue 'lfq' is provided, which can utilize hazard pointers to release memory.
The program has been rewritten using C11 Atomics to support other processor architectures, and it has solved the data race issues, enabling it to pass the runtime detection of Thread Sanitizer.